[test] Use describeTreeView for items rendering edge-case tests
#13168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaviendelangle
added
test
core
12 tasks
flaviendelangle
changed the title
describeTreeView for items rendering edge-case tests
|
Deploy preview: https://deploy-preview-13168--material-ui-x.netlify.app/ |
flaviendelangle
commented
May 17, 2024
| @@ -14,6 +14,13 @@ interface UseTreeItem2UtilsReturnValue { | |||
| status: UseTreeItem2Status; | |||
| } | |||
|
|
|||
| const isItemExpandable = (reactChildren: React.ReactNode) => { | |||
There was a problem hiding this comment.
Here is a bug fix 😆
flaviendelangle
force-pushed
the
jsx-items-test
branch
from
203e59e
to
c88eb63
Compare
LukasTy
approved these changes
May 20, 2024
test/utils/tree-view/describeTreeView/describeTreeView.types.ts
Outdated
Show resolved
Hide resolved
flaviendelangle
changed the title
describeTreeView for items rendering edge-case testsdescribeTreeView for items rendering edge-case tests
Co-authored-by: Lukas <llukas.tyla@gmail.com> Signed-off-by: Flavien DELANGLE <flaviendelangle@gmail.com>
arthurbalduini
pushed a commit
to arthurbalduini/mui-x
that referenced
this pull request
May 23, 2024
…i#13168) Signed-off-by: Flavien DELANGLE <flaviendelangle@gmail.com> Co-authored-by: Lukas <llukas.tyla@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #12433
I had to improve
describeTreeViewto handle these less traditional tests