[DataGrid] Do not miss to escape formulas in CSV export #13888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arminmeh
added
security
arminmeh
changed the title
|
Deploy preview: https://deploy-preview-13888--material-ui-x.netlify.app/ |
packages/x-data-grid/src/hooks/features/export/serializers/csvSerializer.ts
Show resolved
Hide resolved
cherniavskii
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #13790
Delimiter and line break checks were happening before escaping and would keep the values unescaped if they were, for example, large numbers since they would have default delimiter in the formatted value
As mentioned in the issue
formula escape is adding double quotes around the value as recommended in CSV injection
Before: https://stackblitz.com/edit/react-rmcqtb-faujtv?file=Demo.js
After: https://codesandbox.io/p/sandbox/mui-mui-x-x-data-grid-forked-tfkf2x