[docs] Make cell editable in demos #1817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4theushw
commented
Jun 2, 2021
packages/grid/_modules_/grid/hooks/features/keyboard/useGridKeyboard.ts
Outdated
Show resolved
Hide resolved
dtassone
reviewed
Jun 3, 2021
dtassone
reviewed
Jun 3, 2021
packages/grid/x-grid-data-generator/src/renderer/renderEditProgress.tsx
Outdated
Show resolved
Hide resolved
m4theushw
force-pushed
the
make-demos-editable
branch
from
eba40ca
to
3741047
Compare
1 task
m4theushw
force-pushed
the
make-demos-editable
branch
from
7f50193
to
254654c
Compare
DanailH
reviewed
Jun 9, 2021
packages/grid/_modules_/grid/hooks/features/rows/useGridEditRows.ts
Outdated
Show resolved
Hide resolved
m4theushw
force-pushed
the
make-demos-editable
branch
from
170d2b2
to
a24035d
Compare
dtassone
reviewed
Jun 9, 2021
oliviertassinari
changed the title
dtassone
approved these changes
Jun 10, 2021
dtassone
reviewed
Jun 10, 2021
| // See https://github.com/mui-org/material-ui/issues/10534 | ||
| if ( | ||
| (event.target as any).nodeType === 1 && | ||
| !event.currentTarget.contains(event.target as Element) |
There was a problem hiding this comment.
BTW I thought I put a comment about this one, or is it on another PR and we are repeating it again?
m4theushw
force-pushed
the
make-demos-editable
branch
4 times, most recently
from
a0da475
to
6973927
Compare
m4theushw
force-pushed
the
make-demos-editable
branch
from
6973927
to
993314a
Compare
|
I've updated this PR to also make the cells editable in the employee dataset. |
dtassone
approved these changes
Jun 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1625
To be merged after #1772
Previews: