Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGrid] Fix support for getRowId on cell editing #1917

Merged
merged 1 commit into from
Jun 17, 2021

Conversation

m4theushw
Copy link
Member

@m4theushw m4theushw commented Jun 16, 2021

Fixes #1914

Preview: https://codesandbox.io/s/intelligent-silence-psosd?file=/package.json

When creating the update object to be passed to updateRows it was being created only with the id, but getRowId requires the entire row to work.

@m4theushw m4theushw added bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! labels Jun 16, 2021
@m4theushw m4theushw merged commit 95dd7b9 into mui:master Jun 17, 2021
@m4theushw m4theushw deleted the fix-editing-getRowId branch June 17, 2021 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DataGrid] Unexpected behavior using getRowId prop
3 participants