Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGrid] Invert calendar icon color on Chrome when in dark mode #2857

Closed
wants to merge 1 commit into from

Conversation

flaviendelangle
Copy link
Member

@flaviendelangle flaviendelangle commented Oct 13, 2021

Fixes #2855

@mnajdova proposes we fix it on our side for now

Before
image

After
image

@m4theushw
Copy link
Member

m4theushw commented Oct 13, 2021

The bug is not in the DataGrid but in our docs. mui/material-ui#25016 (comment) should fix it and unblock #1805.

@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 21, 2021
@DanailH
Copy link
Member

DanailH commented Oct 22, 2021

The bug is not in the DataGrid but in our docs. mui-org/material-ui#25016 (comment) should fix it and unblock #1805.

@m4theushw do you mean fix in here https://github.com/mui-org/material-ui-x/blob/next/docs/src/modules/XWrapper.js#L4 ?

@m4theushw
Copy link
Member

@DanailH We could set the color scheme in the XWrapper. It would work, but only affecting the data-grid docs. The right thing would be to do mui/material-ui#25016 (comment).

@m4theushw
Copy link
Member

@flaviendelangle Can we close this one? mui/material-ui#25016 should fix #2855 for free.

@flaviendelangle flaviendelangle deleted the calendar-icon branch November 9, 2021 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: out-of-date The pull request has merge conflicts and can't be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DataGrid] Calendar icon is almost invisible when in dark mode
3 participants