[test] Take screenshot of the print export #2881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4theushw
force-pushed
the
screenshot-print-window
branch
from
a80f0c5
to
28571eb
Compare
github-actions
bot
added
the
PR: out-of-date
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
removed
the
PR: out-of-date
DanailH
approved these changes
Oct 19, 2021
DanailH
reviewed
Oct 19, 2021
| @@ -156,7 +156,8 @@ export const useGridPrintExport = ( | |||
| typeof normalizeOptions.pageStyle === 'function' | |||
| ? normalizeOptions.pageStyle() | |||
| : normalizeOptions.pageStyle; | |||
| if (typeof defaultPageStyle !== 'string') { | |||
| if (typeof defaultPageStyle === 'string') { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to remove
webfontloaderbecause the fonts were not loading in the print preview when the browser is opened by playwright.