[DataGrid] Add api pages for data-grid and x-grid #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtassone
changed the title
oliviertassinari
changed the title
There was a problem hiding this comment.
Great start!
We would need two new pages to have them rendered:
- /docs/pages/api-docs/data-grid.js
- /docs/pages/api-docs/x-grid.js
Also, the convention is to add a hyphen when we use an uppercase so:
- /docs/pages/api-docs/data-grid.md
- /docs/pages/api-docs/x-grid.md
See the link generated automatically:
docs/pages/api-docs/xgrid.md
Outdated
|
|
||
| | Rule name | Global class | Description | | ||
| |:-----|:-------------|:------------| | ||
| | <span class="prop-name">root</span> | <span class="prop-name">.MuiDataGrid-root</span> | Styles applied to the root element. |
There was a problem hiding this comment.
Does the classes prop work? It seems it doesn't.
Suggested change
| | <span class="prop-name">root</span> | <span class="prop-name">.MuiDataGrid-root</span> | Styles applied to the root element. | |
| | <span class="prop-name"></span> | <span class="prop-name">.MuiDataGrid-root</span> | Styles applied to the root element. |
docs/pages/api-docs/xgrid.md
Outdated
| | Rule name | Global class | Description | | ||
| |:-----|:-------------|:------------| | ||
| | <span class="prop-name">root</span> | <span class="prop-name">.MuiDataGrid-root</span> | Styles applied to the root element. | ||
| | <span class="prop-name">root</span> | <span class="prop-name">.MuiDataGrid-mainGridContainer</span> | Styles applied to the main container element. |
There was a problem hiding this comment.
root is not implemented here and for all the other keys.
Suggested change
| | <span class="prop-name">root</span> | <span class="prop-name">.MuiDataGrid-mainGridContainer</span> | Styles applied to the main container element. | |
| | <span class="prop-name"></span> | <span class="prop-name">.MuiDataGrid-mainGridContainer</span> | Styles applied to the main container element. |
Actually, we could implement them with the context.
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
oliviertassinari
changed the title
|
I have taken note to fix the link underline in the header in the next batch of small changes for the docs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.