[core] Revert 36124c6
#2907
Merged
[core] Revert 36124c6
#2907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanailH
added
core
There was a problem hiding this comment.
I would prefer this explicitly typed assertion for the exported component props, so that it does not break with any future changes on MUI core (if that's a possibility). But it can be reverted if the reason with keeping is that it could cause a performance issue. 👍
|
I don't think it's needed. I also don't think it brings any performance optimizations. |
m4theushw
approved these changes
Oct 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1902
Based on this comment #2393 (review)
Will keep it in draft, for now, to test if the original issue persists under v5.Seems to be working -> https://codesandbox.io/s/react-forked-v8mur?file=/src/App.tsx