Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first v4 alpha version #291

Merged
merged 4 commits into from
Sep 17, 2020
Merged

first v4 alpha version #291

merged 4 commits into from
Sep 17, 2020

Conversation

dtassone
Copy link
Member

No description provided.

@dtassone
Copy link
Member Author

Packages are not published yet

@@ -3,6 +3,14 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

# [4.0.0-alpha.2](https://github.com/dtassone/material-ui-x/compare/v0.1.67...v4.0.0-alpha.2) (2020-09-17)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noise?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I wonder, would it be better to have a single changelog at the root developers can browse? Instead of having to read a dozen of changelogs when they want to update (in the longer term, once we have more packages?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I was trying lerna version

@oliviertassinari
Copy link
Member

oliviertassinari commented Sep 17, 2020

Should we rename the branch release -> docs?

For context, in the main repo, we use a different repository to have versioning support of the docs, but that's for another day 😁.

@oliviertassinari oliviertassinari changed the title first version first alpha version Sep 17, 2020
@oliviertassinari oliviertassinari changed the title first alpha version first v4 alpha version Sep 17, 2020
@dtassone
Copy link
Member Author

Should we rename the branch release -> docs?

I think release makes more sense in the industry

@dtassone
Copy link
Member Author

For context, in the main repo, we use a different repository to have versioning support of the docs, but that's for another day 😁.

Why?? it sounds overcomplicated 😄

Maybe we should review the process after this release

@oliviertassinari
Copy link
Member

oliviertassinari commented Sep 17, 2020

I think release makes more sense in the industry

I was wondering because we push releases on the master branch which could be confusing with another branch of the same name. The current use case for the release branch is to deploy the documentation. On the main repository. We frequently add commits on the docs branch that aren't released, only so we can update the documentation.

@dtassone
Copy link
Member Author

I think release makes more sense in the industry

I was wondering because we push releases on the master branch which could be confusing with another branch of the same name. The current use case for the release branch is to deploy the documentation. On the main repository. We frequently add commits on the docs branch that aren't released, only so we can update the documentation.

Maybe we should change the netlify config so docs point to the release branch and not the docs branch ?

@oliviertassinari
Copy link
Member

Why?

I think that it started with the requirement to version the documentation https://material-ui.com/versions/, then we double down on using it to not create noise for synching the translations of the documentation. cc @mbrookes.

@dtassone
Copy link
Member Author

Why?

I think that it started with the requirement to version the documentation https://material-ui.com/versions/, then we double down on using it to not create noise for synching the translations of the documentation. cc @mbrookes.

Ahh yes the translations, I remember the conversation now :)

@oliviertassinari
Copy link
Member

Ahh yes the translations, I remember the conversation now :)

We are experimenting with moving the translation to "source" repo. Crowdin has made a chance that reduces noise that seems to make it sustainable. So I guess the only reason for a different docs repository will be versioning, but not sure, hope Matt can 💡 the situation :)

@dtassone dtassone merged commit ae3789f into mui:master Sep 17, 2020
@oliviertassinari oliviertassinari added the release We are shipping :D label Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release We are shipping :D
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants