[DataGrid] Use true content height to dispatch rowsScrollEnd
#2938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4theushw
added
bug 🐛
DanailH
reviewed
Oct 22, 2021
| ), | ||
| }); | ||
| virtualScroller.scrollTop = 12345; | ||
| virtualScroller.dispatchEvent(new Event('scroll')); |
There was a problem hiding this comment.
Nice one. Yes the first time it does fire but the times are the first one it fails.
DanailH
approved these changes
Oct 22, 2021
DanailH
reviewed
Oct 22, 2021
|
|
||
| const rowsInCurrentPage = React.useMemo(() => { | ||
| if (props.pagination && props.paginationMode === 'client') { | ||
| const start = paginationState.pageSize * paginationState.page; |
There was a problem hiding this comment.
Why do you need the pagination here? The infinite loader should only work when there is no pagination.
There was a problem hiding this comment.
Yeah, it could be removed. I only wanted to use the same height used by the virtualization so I copied the code from there. I'll fix this later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview: https://deploy-preview-2938--material-ui-x.netlify.app/components/data-grid/rows/#infinite-loading
On https://next--material-ui-x.netlify.app/components/data-grid/rows/#infinite-loading:
The infinite loading stops at 40 rows. This happens because it was using
containerSizes.dataContainerSizes.heightwhich is not the same height used by the virtualization.