-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DataGrid] Unify filtering / sorting / pagination / rows selectors #2942
Merged
flaviendelangle
merged 21 commits into
mui:next
from
flaviendelangle:selector-prepare-tree-data
Oct 26, 2021
Merged
[DataGrid] Unify filtering / sorting / pagination / rows selectors #2942
flaviendelangle
merged 21 commits into
mui:next
from
flaviendelangle:selector-prepare-tree-data
Oct 26, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaviendelangle
added
the
component: data grid
This is the name of the generic UI component, not the React module!
label
Oct 22, 2021
github-actions
bot
added
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
Oct 22, 2021
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
removed
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
Oct 22, 2021
DanailH
approved these changes
Oct 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking change
component: data grid
This is the name of the generic UI component, not the React module!
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of those breaking change were needed for the Tree Data (especially the migration from a Map to a clean array structure for the selectors).
After this PR, the Tree Data should have no breaking change, I removed the rest from the v5 millestone.
The only selectors without the
grid
prefix are now the selectors ofuseGridColumns
but I want to keep this PR focused on the selectors of the rows lifecycle.New behavior
grid
gridSortedRowIds
=>gridVisibleSortedRowIds
=>gridPaginatedVisibleSortedRowIds
)gridXXXRowIds
andgridXXXRowEntries
.createSelector(someSelector, val => val.length)
, this increase the public API surface for no real valueI did not change the signature of the API functions, but I don't find relevant to return a map in
getVisibleRowModels
.Breaking changes
Selectors
Rows
Sorting
Filter