Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGrid] Fix d.ts file for data-grid #298

Merged
merged 2 commits into from
Sep 18, 2020
Merged

Conversation

dtassone
Copy link
Member

No description provided.

@dtassone dtassone self-assigned this Sep 18, 2020
@dtassone dtassone added bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! labels Sep 18, 2020
@oliviertassinari oliviertassinari changed the title [Data-Grid] Fix d.ts file for data-grid [DataGrid] Fix d.ts file for data-grid Sep 18, 2020
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A reproduction of the fail in v4.0.0-alpha.1: https://codesandbox.io/s/purple-sky-31dy0?file=/demo.tsx.
I can confirm the fix in codesandbox: https://codesandbox.io/s/nifty-wu-ibk76?file=/demo.tsx.

@dtassone dtassone merged commit bb166a8 into mui:master Sep 18, 2020
@oliviertassinari

This comment has been minimized.

@oliviertassinari
Copy link
Member

oliviertassinari commented Sep 18, 2020

Moving #298 (comment) to #299

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants