[docs] Row and cell editing new examples for server-side persistence #3124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaviendelangle
added
docs
m4theushw
reviewed
Nov 15, 2021
docs/src/pages/components/data-grid/editing/CellEditServerSidePersistence.tsx
Outdated
Show resolved
Hide resolved
docs/src/pages/components/data-grid/editing/CellEditServerSidePersistence.tsx
Outdated
Show resolved
Hide resolved
| const handleCellEditCommit = React.useCallback( | ||
| async (params: GridCellEditCommitParams) => { | ||
| // Get the row old value before committing | ||
| const oldRow = apiRef.current.getRow(params.id)!; |
There was a problem hiding this comment.
You can get the row from the rows prop and make this demo Community-compatible.
| } catch (error) { | ||
| setSnackbar({ children: 'Error while saving user', severity: 'error' }); | ||
| // Restore the row in case of error | ||
| apiRef.current.updateRows([oldRow]); |
There was a problem hiding this comment.
The rows prop can be updated instead.
docs/src/pages/components/data-grid/editing/RowEditServerSidePersistence.tsx
Outdated
Show resolved
Hide resolved
|
OK I was way to short on that one sorry, I'll fix those |
m4theushw
reviewed
Nov 23, 2021
| @@ -17,6 +17,14 @@ Set the `editable` property in the `GridColDef` object to `true` to allow editin | |||
|
|
|||
| {{"demo": "pages/components/data-grid/editing/BasicEditingGrid.js", "bg": "inline", "defaultCodeOpen": false}} | |||
|
|
|||
| ### Server-side persistence | |||
There was a problem hiding this comment.
It should not be the first section. The user has just opened the editing page to learn how it works. I think it could be below "Server-side validation".
Co-authored-by: Matheus Wichman <matheushw@outlook.com>
m4theushw
approved these changes
Nov 25, 2021
Co-authored-by: Matheus Wichman <matheushw@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3101