Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Improve rows documentation #3209

Merged
merged 5 commits into from
Nov 23, 2021
Merged

Conversation

flaviendelangle
Copy link
Member

@flaviendelangle flaviendelangle commented Nov 17, 2021

  • Remove strange wordings / repetitions like

Grid rows can be defined with the rows prop.
rows expects an array of objects.
Rows should have this type: GridRowModel[].

  • Improve the updateRows demo to display all the basic cases (I could add a "delete" + "update" to show that we can put several type of actions into one update, but not sure it is worth it)

  • New prop.rows update demo with the same features as the updateRows one

  • Section order change to put the infinite loading section after the updateRows (to keep the two basic row updating sections next to eachother)

  • New warning to encourage people to memoize their rows

  • New link to the density demo to avoid having people updating the row height when they can do otherwise

@flaviendelangle flaviendelangle self-assigned this Nov 17, 2021
flaviendelangle and others added 3 commits November 18, 2021 11:06
Co-authored-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com>
Co-authored-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com>
@flaviendelangle flaviendelangle marked this pull request as ready for review November 19, 2021 10:31
@flaviendelangle flaviendelangle merged commit d6b38df into mui:master Nov 23, 2021
@flaviendelangle flaviendelangle deleted the rows-doc branch November 23, 2021 08:00
@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants