Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix typo in CHANGELOG.md #3214

Merged
merged 1 commit into from
Nov 21, 2021
Merged

Conversation

gjoseph
Copy link
Contributor

@gjoseph gjoseph commented Nov 18, 2021

No description provided.

@flaviendelangle flaviendelangle changed the title Typo in CHANGELOG.md [core] Typo in CHANGELOG.md Nov 18, 2021
@oliviertassinari
Copy link
Member

It looks like that publishing on npm has created some attention. We should probably batch npm release + GitHub release + Blog post + Tweet the next time we face this situation. @gjoseph Thanks

@oliviertassinari oliviertassinari changed the title [core] Typo in CHANGELOG.md [docs] Fix typo in CHANGELOG.md Nov 21, 2021
@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Nov 21, 2021
@oliviertassinari oliviertassinari merged commit 1db8bd8 into mui:master Nov 21, 2021
@flaviendelangle
Copy link
Member

I think we all agree on that
But to do so, we have to start working on the blog post at least one week earlier.
The question here for me was more : Was it worth delaying the release until the blog post was merged, given the fact that we started this blog post too late ?
And I think it was the good decision not to do so. We delayed it by 3 working days. We are now 6 working days after we started the release PR and we still don't have merged the blog post (Matt approved it so I hope we will be able to merge it on Monday).

@oliviertassinari
Copy link
Member

oliviertassinari commented Nov 22, 2021

we have to start working on the blog post at least one week earlier.

Agree, MUI Core v5 blog post was 4 weeks in the making. For the magnitude of the changes in X v5, at least 7 days sounds great. It would probably move faster once we have a dedicated DevRel that becomes owner/accountable for the final content, someone that can guarantee it reach a specific quality target. Right now, Matt & I are bottlenecks.

Was it worth delaying the release until the blog post was merged, given the fact that we started this blog post too late?

From my perspective, I think that it's always worth it, no matter the conditions. I'm saying this because I have never seen a popular open-source project publish a new major version without an announcement (or maybe it happened but didn't notice)

Still, I think that we could shift the question to: is it always worth polishing the blog post further? Or at some point, we can call it good enough, ship even if it's not at the level we target to unlock the value blocked?

I hope we will be able to merge it on Monday

I'm giving it a final look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants