[DataGrid] Fix focus when selecting option with Enter in the singleSelect
#3220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4theushw
added
component: data grid
alexfauquette
approved these changes
Nov 26, 2021
packages/grid/x-data-grid-generator/src/renderer/renderEditCountry.tsx
Outdated
Show resolved
Hide resolved
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
alexfauquette
added a commit
to alexfauquette/mui-x
that referenced
this pull request
Dec 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2880
The solution is a hack involving manually publishing
cellNavigationKeyDownto trigger the keyboard navigation. Another alternative would be to callsetCellFocus, but it's too cumbersome to compute the next id to focus on. The best thing to do would be to not ignore events coming from a portal and adopt a solution like #3158 (comment). I'll not do this for now because it may cause regressions.