[DataGrid] Should not crash when a sort item uses a non-existing column #3224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaviendelangle
commented
Nov 19, 2021
| @@ -164,7 +164,6 @@ | |||
| { "name": "GridEnrichedColDef", "kind": "Type alias" }, | |||
| { "name": "GridExportFormat", "kind": "Type alias" }, | |||
| { "name": "GridFeatureMode", "kind": "Type alias" }, | |||
| { "name": "GridFieldComparatorList", "kind": "Type alias" }, | |||
There was a problem hiding this comment.
It is an internal type never used in anything exported.
flaviendelangle
added
bug 🐛
alexfauquette
approved these changes
Dec 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3020
It unifies the behavior with the filter. If we have an item that uses a non-existing column, we just ignore it.
This is necessary when the
sortModelis controlled. When we change the columns, we automatically clean thesortModel. But when it is controlled, the update can be async and occurs after theapplySortingtriggered by the row change. So we have anapplySortingwith the new columns but the oldsortModel, which causes a crash.Before: https://codesandbox.io/s/datagriddemo-material-demo-forked-r27yc?file=/demo.tsx