[test] Force effect to run on location change #3283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the migration to react-router v6 in #3119, one of the regression tests was not working correctly. The
setTimeoutwas never running, although it should since the clock is mocked. I tried one workaround of waiting a bit but it was not very reliable. This PR contains the proper fix. It turns out that since the same component is used for every route, React doesn't remount the component so the mount effect never run when the route changes. The mount effect was responsible for running all pending timers. It worked with react-router-dom v5 because, in this version, the route component was cloned before, instead of only returned.