[DataGrid] Fix column menu position when closing #3289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4theushw
added
bug 🐛
github-actions
bot
added
the
PR: out-of-date
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
removed
the
PR: out-of-date
| @@ -150,12 +151,22 @@ function GridColumnHeaderItem(props: GridColumnHeaderItemProps) { | |||
| ariaSort = sortDirection === 'asc' ? 'ascending' : 'descending'; | |||
| } | |||
|
|
|||
| React.useEffect(() => { | |||
| if (!showColumnMenuIcon) { | |||
| setShowColumnMenuIcon(columnMenuOpen); | |||
There was a problem hiding this comment.
To only trigger this effect when the columnMenuOpen prop changes, should we remove this !showColumnMenuIcon
Updating from true to true is not a problem no ?
There was a problem hiding this comment.
The purpose of this effect is: showColumnMenuIcon should always reflect the value of columnMenuOpen UNLESS showColumnMenuIcon=true.
It could be rewrote as setShowColumnMenuIcon(value => !value ? columnMenuOpen : value);. By the time this effect run, columnMenuOpen will already be false.
Updating from true to true is not a problem no ?
No, React won't rerender the component if the value didn't change.
flaviendelangle
approved these changes
Dec 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview: https://deploy-preview-3289--material-ui-x.netlify.app/components/data-grid/#commercial-version
Related to #1712 (comment)
Before:
After: