[DataGrid] Deprecate the getValue param for the valueGetter callback

[flaviendelangle]

Fixes #1564
Extracted from #3277

For #3277 I need to call the valueGetter before the column state is initialized to use its value as a grouping key.
But at that point I can't use getBaseCellParams in useGridParamsApi because many api methods / states are not ready yet.
I added a GridValueGetterSimpleParams interface and make valueGetter callable with either the full params or this new interface.

It is not a breaking change since the new incomplete interface is only called for new code in #3277.
But I migrated all our examples to be compatible with #3277 and the main friction point is the getValue param which is an apiRef method that I can't use before useGridParamsApi initialization.

We are using this property in 2 callbacks:

• getRowClassName: I can understand the interest of having a wrapper that given a field, handles the potential valueGetter.

• valueGetter: I don't really see the point of using this property instead of a direct row access. The main difference is that if a col A uses getValue('B') in its valueGetter and if the col B has itself a valueGetter, it will call it. But I think this valueGetter chain adds a lot of not very usefull complexity and that we should deprecate the getValue for the valueGetter callback.

[m4theushw]

Wouldn't be simpler to not create new interfaces and add a warning when getValue is called?

valueGetter: I don't really see the point of using this property instead of a direct row access.

It's useful for when the row structure is nested.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[flaviendelangle]

Wouldn't be simpler to not create new interfaces and add a warning when getValue is called?

I'm only removing getValue for valueGetter so I'm not sure how we could do this, could you elaborate please ?

It's useful for when the row structure is nested.

Would you have an example for valueGetter where it would as useful as possible ?

[m4theushw]

I'm only removing getValue for valueGetter so I'm not sure how we could do this, could you elaborate please ?

I was saying to not create new interfaces and only add a warning if getValue is called.

Would you have an example for valueGetter where it would as useful as possible ?

Are you talking about valueGetter or getValue? I was referring to the first in #3314 (review) to say that it's useful when the data is nested. However, getValue is redundant and can be removed in the major version.

[flaviendelangle]

Are you talking about valueGetter or getValue?

I am talking about the getValue passed as a param to valueGetter.
When it is passed as a param for getRowClassName I don't see any problem. I don't think it's a crucial feature but it does not bother me.
But for valueGetter, it creates chained valueGetter calls and I don't think it's a good idea. Especially with #3277 where it can't have it when calling valueGetter for the grouping process.

[m4theushw]

I don't think it's worth to create another interface to remove getValue. In v6 we'll need to remove it. Instead, we could only flag it as deprecated and be cautious to never call it + display warning if someone calls it.

[flaviendelangle]

This interface has other differences than getValue
Once again it's for the grouping process, so it does not have api or the full rowNode either for instance.

If you want to fully deprecate getValue, I can move it's deprecation from GridValueGetterFullParams to GridCellParams. That was not the goal of this PR but I'm not agaist the idea.
But for GridValueGetterSimpleParams I think we do need another interface.

[m4theushw]

If you want to fully deprecate getValue, I can move it's deprecation from GridValueGetterFullParams to GridCellParams. That was not the goal of this PR but I'm not agaist the idea.

Yes, let's deprecate getValue entirely. The sooner we do, less work we have for v6.

But for GridValueGetterSimpleParams I think we do need another interface.

For now, it's necessary because the api is a required property. However, in v6 this interface can be removed.

[m4theushw]

I'm approving to make #3277 to move faster.

Two things which could be done latter:

• Add a deprecation warning when getValue is called
• Leave a "TODO v6" note so we can find easily it to remove
• Add to [discussion] Preparing v6 #3287

[m4theushw]

If you want to fully deprecate getValue, I can move it's deprecation from GridValueGetterFullParams to GridCellParams. That was not the goal of this PR but I'm not agaist the idea.

Yes, let's deprecate getValue entirely. The sooner we do, less work we have for v6.

But for GridValueGetterSimpleParams I think we do need another interface.

For now, it's necessary because the api is a required property. However, in v6 this interface can be removed.