Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGridPro] Do not expand row children when pressing Shift + Space #3380

Merged
merged 1 commit into from
Dec 9, 2021

Conversation

flaviendelangle
Copy link
Member

@flaviendelangle flaviendelangle commented Dec 8, 2021

Extracted from #3277

Shift + Space is selecting / unselecting the row, the children selection should only be applied when pressing Space without Shift

I also added two small core improvements

  • Do the groupingColDef computation in a useCallback instead of a useMemo to avoid running the prop.groupingColDef callback version on the tree data grouping column when the tree data is not enabled.
  • Use the rowNode from the params in the cellKeyDown event instead of using the apiRef (helps us remove an useless check)

@flaviendelangle flaviendelangle merged commit 134611f into mui:master Dec 9, 2021
@flaviendelangle flaviendelangle deleted the tree-data-keyboard branch December 9, 2021 08:26
@zannager zannager added component: data grid This is the name of the generic UI component, not the React module! plan: Pro Impact at least one Pro user labels Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module! plan: Pro Impact at least one Pro user
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants