Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Include @mui/x-data-grid as dependency in the CodeSandbox #3396

Merged
merged 2 commits into from
Dec 13, 2021
Merged

[docs] Include @mui/x-data-grid as dependency in the CodeSandbox #3396

merged 2 commits into from
Dec 13, 2021

Conversation

m4theushw
Copy link
Member

@m4theushw m4theushw added the docs Improvements or additions to the documentation label Dec 11, 2021
@oliviertassinari
Copy link
Member

oliviertassinari commented Dec 13, 2021 •
edited

A side note, I believe we can kill this line:

https://github.com/mui-org/material-ui-x/blob/389b9e64bec7b150763c4e23b259bd8e8814b722/docs/pages/_app.js#L47

@mui/styles is not a peer dependency of the x packages anymore.

@m4theushw
Copy link
Member Author

@oliviertassinari Not yet, the custom cell renderers in @mui/x-data-grid-generator still use @mui/styles (we need to migrate them). However, I agree that this import should only be added if the generator is used.

@m4theushw m4theushw merged commit 219f11b into mui:master Dec 13, 2021
@m4theushw m4theushw deleted the codesandbox-deps branch December 13, 2021 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flaviendelangle flaviendelangle flaviendelangle approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@m4theushw @oliviertassinari @flaviendelangle