[test] Add end-to-end test missing id #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
component: data grid
oliviertassinari
force-pushed
the
add-e2e-test
branch
2 times, most recently
from
aa018b0
to
937ab24
Compare
| expect(() => { | ||
| render( | ||
| <ErrorBoundary ref={errorRef}> | ||
| {/* @ts-expect-error missing id */} |
There was a problem hiding this comment.
A test for the types for free :)
oliviertassinari
force-pushed
the
add-e2e-test
branch
from
937ab24
to
b764d98
Compare
dtassone
approved these changes
Sep 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure we won't have regressions for #349. Tests are cheap, we can add a lot without carrying about how much time to takes to run, about 120ms per test right now.