Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] Improve warning and docs for layouting #405

Merged
merged 5 commits into from
Oct 7, 2020
Merged

[DataGrid] Improve warning and docs for layouting #405

merged 5 commits into from
Oct 7, 2020

Conversation

RobertAron
Copy link
Contributor

@RobertAron RobertAron commented Oct 7, 2020 •
edited by oliviertassinari

Closes #382

@RobertAron
Copy link
Contributor Author

RobertAron commented Oct 7, 2020 •
edited

I wasn't able to test this locally. Is there a way to import the project using something like npm link to set up a sandbox to test things in?

I was able to confirm the docs were updated locally.

@oliviertassinari oliviertassinari changed the title updated warnings and docs for datagrid [DataGrid updated warnings and docs for datagrid Oct 7, 2020
@oliviertassinari oliviertassinari changed the title [DataGrid updated warnings and docs for datagrid [DataGrid] u Oct 7, 2020
@oliviertassinari oliviertassinari changed the title [DataGrid] u [DataGrid] Improve warning and docs for layouting Oct 7, 2020
@oliviertassinari oliviertassinari added component: data grid This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation labels Oct 7, 2020
@oliviertassinari
Copy link
Member

oliviertassinari commented Oct 7, 2020 •
edited

I wasn't able to test this locally. Is there a way to import the project using something like npm link to set up a sandbox to test things in?

@RobertAron Thanks for looking into it. We handle this repository as an extension of the main repo. What's documented in https://github.com/mui-org/material-ui/blob/next/CONTRIBUTING.md should work almost identically here.

oliviertassinari
oliviertassinari approved these changes Oct 7, 2020
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm working on adding a CONTRIBUTING.md file. This will link the file from the main repo and detail the requirement on the CLA. For this contribution, considering that the changes were initially proposed by me. I think that we are good, no need to sign anything. Thanks!

@oliviertassinari
Copy link
Member

Follow-up done in #406

@oliviertassinari oliviertassinari merged commit 14e4509 into mui:master Oct 7, 2020
dtassone pushed a commit to dtassone/material-ui-x that referenced this pull request Nov 9, 2020
@RobertAron @dtassone
[DataGrid] Improve warning and docs for layouting (mui#405)
163ce18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtassone dtassone dtassone approved these changes

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
component: data grid This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DataGrid] Doesn't seem to work within a Grid component
3 participants
@RobertAron @oliviertassinari @dtassone