[DataGrid] Change ColumnsHeader component tabIndex to -1 #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
requested changes
Oct 20, 2020
There was a problem hiding this comment.
I don't think that the row should be focusable. I don't think that it makes sense to give the row focus on click or to allow a programmatic focus. We can silence the eslint rule: https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/master/docs/rules/interactive-supports-focus.md#rule-details
dtassone
approved these changes
Oct 20, 2020
oliviertassinari
approved these changes
Oct 21, 2020
oliviertassinari
added
bug 🐛
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
dtassone
pushed a commit
to dtassone/material-ui-x
that referenced
this pull request
Nov 9, 2020
* [DataGrid] Change ColumnsHeader component tabIndex to -1 * Add eslint-disable-next-line and remove unwanted tabIndex * Update packages/grid/_modules_/grid/components/column-headers.tsx Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com> Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've accidentally set a
tabIndex="0"on theColumnsHeadercomponent. I'm setting it to-1since now it focuses the entire row.PS: We need the
tabIndexbecause without it the linter fails withElements with the 'row' interactive role must be focusable. That is because that samedivhas arole=row