[DataGrid] Apply review from #412 #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
the
component: data grid
| pagination: { ...INITIAL_PAGINATION_STATE }, | ||
| options: { ...DEFAULT_GRID_OPTIONS }, | ||
| pagination: INITIAL_PAGINATION_STATE, | ||
| options: DEFAULT_GRID_OPTIONS, |
There was a problem hiding this comment.
The state will be part of the public API, from what I understand from #190. It's important that the state is immutable. If there are leaks, we need to find and fix them. This will help spot them, it also removes runtime work that shouldn't be necessary.
|
Fail because of #506 (comment). |
dtassone
approved these changes
Nov 2, 2020
DanailH
approved these changes
Nov 3, 2020
oliviertassinari
force-pushed
the
batch-small-changes-v44
branch
from
727173f
to
424b97a
Compare
dtassone
pushed a commit
to dtassone/material-ui-x
that referenced
this pull request
Nov 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply the feedback forgotten from #412