Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Remove dead logic #5282

Merged
merged 1 commit into from Jun 22, 2022

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Jun 21, 2022

Redirects only take effect in the development, not production (because of next export). I would argue it was never needed in the first place for the migration, and since it's done, not anymore.

I have found this doing a quick review on something unrelated.

@oliviertassinari oliviertassinari added the core Infrastructure work going on behind the scenes label Jun 21, 2022
@mui-bot
Copy link

mui-bot commented Jun 21, 2022

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 234.4 483.4 295.9 314.34 91.227
Sort 100k rows ms 429.4 788.6 689.5 642.58 120.542
Select 100k rows ms 87.7 195.7 184.2 160.62 38.011
Deselect 100k rows ms 86.7 187.6 171.4 145.7 37.06

Generated by 🚫 dangerJS against bee87c7

@oliviertassinari oliviertassinari merged commit 8b4de81 into mui:master Jun 22, 2022
@oliviertassinari oliviertassinari deleted the remove-dead-code-v3 branch June 22, 2022 11:36
joserodolfofreitas pushed a commit to joserodolfofreitas/mui-x that referenced this pull request Jul 15, 2022
alexfauquette pushed a commit to alexfauquette/mui-x that referenced this pull request Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants