Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] Add prop to keep modifications while processing props #5309

Merged
merged 4 commits into from
Jul 27, 2022
Merged

[DataGrid] Add prop to keep modifications while processing props #5309

merged 4 commits into from
Jul 27, 2022

Conversation

m4theushw
Copy link
Member

Fixes #5218

@m4theushw m4theushw added component: data grid This is the name of the generic UI component, not the React module! feature: Editing Related to the data grid Editing feature labels Jun 24, 2022
@mui-bot
Copy link

mui-bot commented Jun 24, 2022 •
edited
Loading

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 257 599.8 499.4 432.7 146.333
Sort 100k rows ms 497.4 835.5 798.1 731.62 122.825
Select 100k rows ms 175.7 314 237 243.66 48.149
Deselect 100k rows ms 122.7 235.2 204.6 188.34 39.481

Generated by 🚫 dangerJS against 1c6426f

@m4theushw m4theushw merged commit 4dabd10 into mui:master Jul 27, 2022
@m4theushw m4theushw deleted the dont-ignore-modifications branch July 27, 2022 01:09
alexfauquette pushed a commit to alexfauquette/mui-x that referenced this pull request Aug 26, 2022
@m4theushw @alexfauquette
[DataGrid] Add prop to keep modifications while processing props (mui…
b29b73e 
…#5309)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flaviendelangle flaviendelangle flaviendelangle approved these changes

Assignees
No one assigned
Labels
component: data grid This is the name of the generic UI component, not the React module! feature: Editing Related to the data grid Editing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Values lost on commit when using preProcessEditCellProps with new editing API
3 participants
@m4theushw @mui-bot @flaviendelangle