[DataGrid] Fix blank space when using dynamic row height with pagination #5315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4theushw
added
bug 🐛
|
These are the results for the performance tests:
|
m4theushw
commented
Jun 24, 2022
Comment on lines
-120
to
+123
| const lastMeasuredIndex = Math.max(0, apiRef.current.unstable_getLastMeasuredRowIndex()); | ||
| const allRowsMeasured = lastMeasuredIndex === Infinity; | ||
| const lastMeasuredIndexRelativeToAllRows = apiRef.current.unstable_getLastMeasuredRowIndex(); | ||
| const lastMeasuredIndexRelativeToCurrentPage = | ||
| lastMeasuredIndexRelativeToAllRows - (currentPage.range?.firstRowIndex || 0); | ||
| const lastMeasuredIndex = Math.max(0, lastMeasuredIndexRelativeToCurrentPage); |
Comment on lines
+125
to
+129
| let allRowsMeasured = lastMeasuredIndex === Infinity; | ||
| if (currentPage.range?.lastRowIndex && !allRowsMeasured) { | ||
| // Check if all rows in this page are already measured | ||
| allRowsMeasured = lastMeasuredIndex >= currentPage.range.lastRowIndex; | ||
| } |
2 tasks
joserodolfofreitas
pushed a commit
to joserodolfofreitas/mui-x
that referenced
this pull request
Jul 15, 2022
alexfauquette
pushed a commit
to alexfauquette/mui-x
that referenced
this pull request
Aug 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1st bug preview: https://codesandbox.io/s/dynamicrowheightgrid-demo-mui-x-forked-6i5ct0?file=/demo.tsx
2nd bug preview: https://codesandbox.io/s/dynamicrowheightgrid-demo-mui-x-forked-uw5jw7?file=/demo.tsx
Fixes #5312
The problem here was that the last measured index was relative to the
rowsprop, not the current visible rows, as consequence it was using the exponential search instead of the binary search.