Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Make a clear difference between the license and license key #5316

Merged
merged 1 commit into from
Jul 10, 2022

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Jun 25, 2022

The issues I'm trying to solve:

  1. A license is not a license key. Instead, we can distinguish an order and a license key.
  2. "or later" can be confused with "or older", I think that it depends on how you consider the direction of time. Instead, we can focus on the version number, not when it was released.
  3. Saying "only compatible" is not accurate. It the default behavior, but we can work around it. Instead, we can say it's the default behavior.

https://mui.com/x/advanced-components/#license-key-installation

@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Jun 25, 2022
@mui-bot
Copy link

mui-bot commented Jun 25, 2022

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 242.1 430.3 323.6 325.6 72.44
Sort 100k rows ms 440.9 790.5 742.7 660.76 131.468
Select 100k rows ms 101.4 220.3 143.9 153.22 40.057
Deselect 100k rows ms 98.1 199.8 188.6 162.4 35.307

Generated by 🚫 dangerJS against 304a7da

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 7, 2022
@github-actions
Copy link

github-actions bot commented Jul 7, 2022

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 10, 2022
@oliviertassinari oliviertassinari changed the title [docs] License !== license key [docs] Make a clear difference between the license and license key Jul 10, 2022
@oliviertassinari oliviertassinari merged commit aaaa67b into mui:master Jul 10, 2022
@oliviertassinari oliviertassinari deleted the clarify-warning branch July 10, 2022 23:21
joserodolfofreitas pushed a commit to joserodolfofreitas/mui-x that referenced this pull request Jul 15, 2022
alexfauquette pushed a commit to alexfauquette/mui-x that referenced this pull request Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants