Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Include playground pages in tsconfig #5367

Merged
merged 1 commit into from
Jul 8, 2022
Merged

[core] Include playground pages in tsconfig #5367

merged 1 commit into from
Jul 8, 2022

Conversation

cherniavskii
Copy link
Member

When using data grid in playground pages TS is complaining about some imports.

Before:
Screenshot 2022-06-30 at 16 21 34
After:
Screenshot 2022-06-30 at 16 22 00

@mui-bot
Copy link

mui-bot commented Jul 1, 2022

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 253.9 678.7 383.7 417.64 160.872
Sort 100k rows ms 467.6 1,031 711.7 813.94 203.694
Select 100k rows ms 180.7 271.5 197 206.22 33.374
Deselect 100k rows ms 112.4 265.4 211.6 197.48 60.433

Generated by 🚫 dangerJS against 404dd38

@cherniavskii cherniavskii added the core Infrastructure work going on behind the scenes label Jul 4, 2022
@cherniavskii cherniavskii merged commit 21c1f6c into mui:master Jul 8, 2022
@cherniavskii cherniavskii deleted the fix-tsconfig-for-playground-pages branch July 8, 2022 16:44
joserodolfofreitas pushed a commit to joserodolfofreitas/mui-x that referenced this pull request Jul 15, 2022
@cherniavskii @joserodolfofreitas
[core] Include playground pages in tsconfig (mui#5367)
0888f8e
alexfauquette pushed a commit to alexfauquette/mui-x that referenced this pull request Aug 26, 2022
@cherniavskii @alexfauquette
[core] Include playground pages in tsconfig (mui#5367)
d68fed1
@cherniavskii cherniavskii mentioned this pull request May 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m4theushw m4theushw m4theushw approved these changes

@flaviendelangle flaviendelangle Awaiting requested review from flaviendelangle

Assignees
No one assigned
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cherniavskii @mui-bot @m4theushw