Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGridPro] Improve pinned column headers accessibility #5370

Merged
merged 2 commits into from
Jul 13, 2022
Merged

[DataGridPro] Improve pinned column headers accessibility #5370

merged 2 commits into from
Jul 13, 2022

Conversation

cherniavskii
Copy link
Member

Fixes #5364

I've added axe-core to our dependencies and created the first test with a check for one specific accessibility rule.
We can add more rules in the future.

@cherniavskii cherniavskii added accessibility a11y component: data grid This is the name of the generic UI component, not the React module! labels Jul 1, 2022
@mui-bot
Copy link

mui-bot commented Jul 1, 2022 •
edited

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 256.1 516.2 416.7 375.08 102.394
Sort 100k rows ms 470.7 949.4 797.2 760.02 165.816
Select 100k rows ms 134.6 201.1 176 175.38 24.414
Deselect 100k rows ms 105.2 203.8 185.4 163.82 38.882

Generated by 🚫 dangerJS against 1ed3a73

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 6, 2022
@github-actions

This comment was marked as outdated.

Sign in to view
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 6, 2022
m4theushw
m4theushw approved these changes Jul 12, 2022
View reviewed changes
Copy link
Member

@m4theushw m4theushw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍 to add more accessibility tests with axe-core.

@cherniavskii cherniavskii added the plan: Pro Impact at least one Pro user label Jul 13, 2022
@cherniavskii cherniavskii merged commit 660ce53 into mui:master Jul 13, 2022
@cherniavskii cherniavskii deleted the column-headers-accessibility branch July 13, 2022 07:53
joserodolfofreitas pushed a commit to joserodolfofreitas/mui-x that referenced this pull request Jul 15, 2022
@cherniavskii @joserodolfofreitas
[DataGridPro] Improve pinned column headers accessibility (mui#5370)
5797991
alexfauquette pushed a commit to alexfauquette/mui-x that referenced this pull request Aug 26, 2022
@cherniavskii @alexfauquette
[DataGridPro] Improve pinned column headers accessibility (mui#5370)
8442cda
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m4theushw m4theushw m4theushw approved these changes

Assignees
No one assigned
Labels
accessibility a11y component: data grid This is the name of the generic UI component, not the React module! plan: Pro Impact at least one Pro user
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[data grid] Pinned columns and rows in Data Grid Pro fail accessibility test
3 participants
@cherniavskii @mui-bot @m4theushw