[DataGrid] Fix some filters being removed from filter model on filter panel open

[cherniavskii]

Fixes #5402

Preview: https://deploy-preview-5403--material-ui-x.netlify.app/x/react-data-grid/demo/

[mui-bot]

These are the results for the performance tests:

Test case	Unit	Min	Max	Median	Mean	σ
Filter 100k rows	ms	259.8	581.7	404.4	388.46	113.201
Sort 100k rows	ms	478.3	1,011.8	675.6	766.74	183.696
Select 100k rows	ms	127	200.7	189	174.3	27.844
Deselect 100k rows	ms	94	262.5	262.5	186.12	75.653

Generated by 🚫 dangerJS against d2611b0

[alexfauquette]

Nice fix

Relying on th existence of a component to know is the filter is active when item.value===undefined seems flaky but I do not have other solutions

[flaviendelangle]

An alternative would be to create a new optional property on GridFilterOperator named hasValue?: (item: GridFilterItem) => boolean with a default value being hasValue: item => item !== undefined

It would work on weird edge cases (for instance if a user creates a custom panel and rely on the name of the operator to display a component instead of InputComponent, that's not how it should be used so maybe having it break is not that problematic).

[m4theushw]

Do you want to merge this to include in the release?

[cherniavskii]

Do you want to merge this to include in the release?

No, there might be some room for improvement as pointed out by Flavien

[cherniavskii]

An alternative would be to create a new optional property on GridFilterOperator named hasValue?: (item: GridFilterItem) => boolean with a default value being hasValue: item => item !== undefined

Thanks @flaviendelangle
I've used a slightly different signature: requiresFilterValue?: boolean to simplify things. It's better than just checking InputComponent 👍