Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] Improve French (fr-FR) locale #5420

Merged
merged 4 commits into from
Jul 8, 2022
Merged

[DataGrid] Improve French (fr-FR) locale #5420

merged 4 commits into from
Jul 8, 2022

Conversation

Zenoo
Copy link
Contributor

@Zenoo Zenoo commented Jul 7, 2022

Adds missing translations for the French language (fr-FR) locale - #3211

@mui-bot
Copy link

mui-bot commented Jul 7, 2022 •
edited

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 275.9 434.6 385.6 356.68 62.808
Sort 100k rows ms 472.5 928.3 840.4 767.1 163.86
Select 100k rows ms 100.3 197.5 157 156.66 35.515
Deselect 100k rows ms 107 195.2 183.9 168.24 32.035

Generated by 🚫 dangerJS against 259db84

@Zenoo @flaviendelangle
Update packages/grid/x-data-grid/src/locales/frFR.ts
f46d7d3 
Co-authored-by: Flavien DELANGLE <flaviendelangle@gmail.com>
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 8, 2022
@github-actions
Copy link

github-actions bot commented Jul 8, 2022

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 8, 2022
@flaviendelangle flaviendelangle added component: data grid This is the name of the generic UI component, not the React module! l10n localization labels Jul 8, 2022
@flaviendelangle flaviendelangle changed the title [l10n] Improve French (fr-FR) locale (#3211) [data grid] Improve French (fr-FR) locale (#3211) Jul 8, 2022
@flaviendelangle flaviendelangle changed the title [data grid] Improve French (fr-FR) locale (#3211) [DataGrid] Improve French (fr-FR) locale (#3211) Jul 8, 2022
@flaviendelangle flaviendelangle merged commit d61b422 into mui:master Jul 8, 2022
@oliviertassinari oliviertassinari changed the title [DataGrid] Improve French (fr-FR) locale (#3211) [DataGrid] Improve French (fr-FR) locale Jul 8, 2022
joserodolfofreitas pushed a commit to joserodolfofreitas/mui-x that referenced this pull request Jul 15, 2022
@Zenoo @joserodolfofreitas
[DataGrid] Improve French (fr-FR) locale (mui#3211) (mui#5420)
63c1356
alexfauquette pushed a commit to alexfauquette/mui-x that referenced this pull request Aug 26, 2022
@Zenoo @alexfauquette
[DataGrid] Improve French (fr-FR) locale (mui#3211) (mui#5420)
4fb4b33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flaviendelangle flaviendelangle flaviendelangle approved these changes

Assignees
No one assigned
Labels
component: data grid This is the name of the generic UI component, not the React module! l10n localization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Zenoo @mui-bot @flaviendelangle