Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Clarify the scope of support for MUI X #5423

Merged
merged 9 commits into from
Jul 14, 2022
Merged

[docs] Clarify the scope of support for MUI X #5423

merged 9 commits into from
Jul 14, 2022

Conversation

joserodolfofreitas
Copy link
Member

@joserodolfofreitas joserodolfofreitas commented Jul 8, 2022 •
edited

Motivation

It's not clear to users that "Professional support" doesn't include MUI Core.
We're seeing MUI X customers expecting to get professional support extended to MUI Core.

Examples:

Preview

https://deploy-preview-5423--material-ui-x.netlify.app/x/introduction/support/#technical-support

@mui-bot
Copy link

mui-bot commented Jul 8, 2022 •
edited

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 251.9 509 386.5 383.9 82.464
Sort 100k rows ms 450.3 822.4 731.6 702.06 132.103
Select 100k rows ms 116.3 208.9 183.6 175.74 31.734
Deselect 100k rows ms 105.3 204.5 166.3 159.56 32.552

Generated by 🚫 dangerJS against caba3af

@joserodolfofreitas joserodolfofreitas added the docs Improvements or additions to the documentation label Jul 8, 2022
@joserodolfofreitas joserodolfofreitas mentioned this pull request Jul 8, 2022
Merged
1 task
joserodolfofreitas and others added 2 commits July 11, 2022 10:43
@joserodolfofreitas @oliviertassinari
Olivier's CR suggestions from code review
fdfb839 
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
@joserodolfofreitas
Rename Professional to Technical support
68fc5cf
@joserodolfofreitas joserodolfofreitas changed the title [docs] Add info pointing that MUI Core is not covered by professional support [docs] Add info pointing that MUI Core is not covered by technical support Jul 11, 2022
@joserodolfofreitas joserodolfofreitas changed the title [docs] Add info pointing that MUI Core is not covered by technical support [docs] Clear the scope of support for MUI X. Jul 14, 2022
@joserodolfofreitas joserodolfofreitas changed the title [docs] Clear the scope of support for MUI X. [docs] Clear the scope of support for MUI X Jul 14, 2022
@joserodolfofreitas joserodolfofreitas changed the title [docs] Clear the scope of support for MUI X [docs] Clarify the scope of support for MUI X Jul 14, 2022
@joserodolfofreitas
Copy link
Member Author

I'm moving forward with merging this PR to release it with 5.13.1.
It unlocks the new link at orders and other changes on the Material UI repo.

@joserodolfofreitas joserodolfofreitas merged commit a3bb2ca into mui:master Jul 14, 2022
joserodolfofreitas added a commit to joserodolfofreitas/mui-x that referenced this pull request Jul 15, 2022
@joserodolfofreitas @oliviertassinari
[docs] Clarify the scope of support for MUI X (mui#5423)
d8c67c2 
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
@oliviertassinari
Copy link
Member

Looks good 👍

alexfauquette pushed a commit to alexfauquette/mui-x that referenced this pull request Aug 26, 2022
@joserodolfofreitas @oliviertassinari @alexfauquette
[docs] Clarify the scope of support for MUI X (mui#5423)
7f638fa 
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari left review comments

@samuelsycamore samuelsycamore Awaiting requested review from samuelsycamore

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@joserodolfofreitas @mui-bot @oliviertassinari