Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Add technical support link to _redirects #5428

Conversation

joserodolfofreitas
Copy link
Member

The link will be initially used on the store's keymailer.

More on: https://github.com/mui/mui-store/pull/187

@joserodolfofreitas joserodolfofreitas added the core Infrastructure work going on behind the scenes label Jul 8, 2022
@mui-bot
Copy link

mui-bot commented Jul 8, 2022

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 283 564.2 335.1 372.72 103.186
Sort 100k rows ms 498.9 856.9 674.5 692.42 133.03
Select 100k rows ms 132.9 308.2 183.4 196.24 59.308
Deselect 100k rows ms 100.2 220.8 171.3 159.94 41.104

Generated by 🚫 dangerJS against d3c2621

@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Jul 8, 2022
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 9, 2022
@github-actions
Copy link

github-actions bot commented Jul 9, 2022

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link
Member

@mbrookes mbrookes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will need to update the wording in the docs

docs/public/_redirects Outdated Show resolved Hide resolved
@mbrookes mbrookes changed the title [core] Add professional support link to _redirects [core] Add technical support link to _redirects Jul 9, 2022
@oliviertassinari
Copy link
Member

Should we rename https://mui.com/store/legal/mui-x-eula/#support to "Technical Support" too?

@mbrookes
Copy link
Member

We could do for consistency (for the section header only), but it isn't incorrect, just less specific.

Update docs/public/_redirects

Co-authored-by: Matt <github@nospam.33m.co>
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 11, 2022
@oliviertassinari oliviertassinari dismissed mbrookes’s stale review July 11, 2022 10:28

changes requested applied

@joserodolfofreitas joserodolfofreitas merged commit 6107488 into mui:master Jul 13, 2022
joserodolfofreitas added a commit to joserodolfofreitas/mui-x that referenced this pull request Jul 15, 2022
* Add techincal support link to redirect

Co-authored-by: Matt <github@nospam.33m.co>
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
alexfauquette pushed a commit to alexfauquette/mui-x that referenced this pull request Aug 26, 2022
* Add techincal support link to redirect

Co-authored-by: Matt <github@nospam.33m.co>
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants