Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pickers] Improve German (de-DE) locale #5447

Merged
merged 4 commits into from
Jul 14, 2022
Merged

[pickers] Improve German (de-DE) locale #5447

merged 4 commits into from
Jul 14, 2022

Conversation

sebastianfrey
Copy link
Contributor

Add missing translations for DatePickers.

@mui-bot
Copy link

mui-bot commented Jul 11, 2022 •
edited

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 269.2 608.1 489.3 444.42 136.994
Sort 100k rows ms 569.3 1,186.4 569.3 952.26 233.804
Select 100k rows ms 152.8 231.7 204.4 199.8 25.967
Deselect 100k rows ms 111.2 274.7 218 196.88 64.081

Generated by 🚫 dangerJS against d3289f3

@ximex
Copy link
Contributor

ximex commented Jul 11, 2022

maybe Uhrzeit instead of Zeit?

@sebastianfrey
Copy link
Contributor Author

sebastianfrey commented Jul 11, 2022 •
edited

maybe Uhrzeit instead of Zeit?

@ximex Absolutely, no idea what got into me. Possibly not enough sleep ;-) I will fix it.

@sebastianfrey sebastianfrey mentioned this pull request Jul 12, 2022
Closed
@flaviendelangle flaviendelangle changed the title [DatePickers][l10n] Improve German (de-DE) locale [pickers] Improve German (de-DE) locale Jul 12, 2022
@m4theushw m4theushw added the l10n localization label Jul 12, 2022
@ximex
Copy link
Contributor

ximex commented Jul 13, 2022

fixes part of #3211

joserodolfofreitas
joserodolfofreitas reviewed Jul 13, 2022
View reviewed changes
Copy link
Member

@joserodolfofreitas joserodolfofreitas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution, @sebastianfrey!

I'm bringing a few suggestions from @ximex in
#5459.

packages/x-date-pickers/src/locales/deDE.ts Outdated Show resolved Hide resolved
packages/x-date-pickers/src/locales/deDE.ts Outdated Show resolved Hide resolved
packages/x-date-pickers/src/locales/deDE.ts Outdated Show resolved Hide resolved
@sebastianfrey
Copy link
Contributor Author

@joserodolfofreitas I have applied the suggestions from @ximex in #5459.

@sebastianfrey
Copy link
Contributor Author

sebastianfrey commented Jul 13, 2022 •
edited

@joserodolfofreitas One thing I have noted is, that hoursClockNumberText, minutesClockNumberText or secondsClockNumberText do not distinguish between 1 and other values like 0 or all values greater then 1:

The following table demonstrates the issue:

en-EN:

Value Actual Target
0 0 minutes ✔️ 0 minutes ✔️
1 1 minutes ❌ 1 minute ✔️
2 2 minutes ✔️ 2 minutes ✔️

de-DE:

Value Actual Target
0 0 Minuten ✔️ 0 Minuten ✔️
1 1 Minuten ❌ 1 Minute ✔️
2 2 Minuten ✔️ 2 Minuten ✔️

@ximex
Copy link
Contributor

ximex commented Jul 13, 2022

i'm happy with this PR. but yes we could improve it if we look on the count and use singular/plural text form

joserodolfofreitas
joserodolfofreitas approved these changes Jul 13, 2022
View reviewed changes
Copy link
Member

@joserodolfofreitas joserodolfofreitas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, @sebastianfrey!
I've created a new ticket to track the singular/plural issue.

@joserodolfofreitas joserodolfofreitas mentioned this pull request Jul 13, 2022
Open
2 tasks
@m4theushw m4theushw merged commit 116123f into mui:master Jul 14, 2022
joserodolfofreitas pushed a commit to joserodolfofreitas/mui-x that referenced this pull request Jul 15, 2022
@sebastianfrey @joserodolfofreitas
[pickers] Improve German (de-DE) locale (mui#5447)
8ba47b2
alexfauquette pushed a commit to alexfauquette/mui-x that referenced this pull request Aug 26, 2022
@sebastianfrey @alexfauquette
[pickers] Improve German (de-DE) locale (mui#5447)
d83e1e0
@sebastianfrey sebastianfrey deleted the x-date-pickers-de-locales branch September 12, 2022 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joserodolfofreitas joserodolfofreitas joserodolfofreitas approved these changes

Assignees
No one assigned
Labels
l10n localization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sebastianfrey @mui-bot @ximex @joserodolfofreitas @m4theushw