Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[l10n] Improve Romanian (ro-RO) locale #5449

Merged
merged 1 commit into from
Jul 11, 2022
Merged

[l10n] Improve Romanian (ro-RO) locale #5449

merged 1 commit into from
Jul 11, 2022

Conversation

rolule
Copy link
Contributor

@rolule rolule commented Jul 11, 2022

Add missing translation keys to roRO locale

@mui-bot
Copy link

mui-bot commented Jul 11, 2022

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 463.9 995.3 624.4 643.24 187.652
Sort 100k rows ms 971.9 1,902.7 1,685.1 1,398.34 342.756
Select 100k rows ms 302.8 442.7 358.6 362.72 46.144
Deselect 100k rows ms 229.2 556.4 417.3 402.34 106.295

Generated by 🚫 dangerJS against 19adb4a

@alexfauquette alexfauquette added the l10n localization label Jul 11, 2022
@alexfauquette
Copy link
Member

Thanks for your contribution, tests failed for internal server reason, I reruned them 👍

alexfauquette
alexfauquette approved these changes Jul 11, 2022
View reviewed changes
Copy link
Member

@alexfauquette alexfauquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement, it should be availabe in next release :)

@alexfauquette alexfauquette merged commit 0fd7ff4 into mui:master Jul 11, 2022
@rolule rolule deleted the l10n/improve-roRO-locale branch July 13, 2022 07:33
joserodolfofreitas pushed a commit to joserodolfofreitas/mui-x that referenced this pull request Jul 15, 2022
@rolule @joserodolfofreitas
[l10n] Improve Romanian (ro-RO) locale (mui#5449)
dfee9d3
alexfauquette pushed a commit to alexfauquette/mui-x that referenced this pull request Aug 26, 2022
@rolule @alexfauquette
[l10n] Improve Romanian (ro-RO) locale (mui#5449)
18df0ff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexfauquette alexfauquette alexfauquette approved these changes

Assignees
No one assigned
Labels
l10n localization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rolule @mui-bot @alexfauquette