-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Fix internal link to valueParser
#5450
Conversation
These are the results for the performance tests:
|
@@ -73,7 +73,7 @@ In the following demo, a formatter is used to display the tax rate's decimal val | |||
|
|||
The value generated is only used for rendering purposes. | |||
Filtering and sorting do not rely on the formatted value. | |||
Use the [`valueParser`](/x/react-data-grid/cells/#value-parser) to support filtering. | |||
Use the [`valueParser`](/x/react-data-grid/editing/#value-parser-and-value-setter) to support filtering. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that it's a bit confusing. We say, use the value parser to implement customer filtering input value parser
and then link people to a different feature: edition, which is not filtering.
Maybe it would make sense to have the same section in the documentation as https://mui.com/x/react-data-grid/filtering/#parsing-values but for the column filtering.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Flavien had commented a bit on this problem in #4956 (comment). I guess the demo in https://mui.com/x/react-data-grid/column-definition/#value-formatter is a good illustration of the need for valueParser
. When you search for 20 you get no results 🙃. Link it here
The chart #3215 (comment) helps understand how this works 👍 . It could help to have documentation about it. The tricky part might be, how do we have developers find it when they need it?
Fix #5176