Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pickers] Add Spanish (es-ES) locale #5468

Merged
merged 1 commit into from
Jul 12, 2022
Merged

[pickers] Add Spanish (es-ES) locale #5468

merged 1 commit into from
Jul 12, 2022

Conversation

felixh10r
Copy link
Contributor

Following up on #3211, I'd like to provide Spanish translations for the Date Picker component.

@mui-bot
Copy link

mui-bot commented Jul 12, 2022 •
edited

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 260.6 701.2 414.2 425.58 161.595
Sort 100k rows ms 484 1,021.4 682.9 758.52 177.003
Select 100k rows ms 149.4 308.1 224.1 228.48 56.77
Deselect 100k rows ms 105.9 223.1 200.9 182.22 40.511

Generated by 🚫 dangerJS against ae75b5f

@m4theushw m4theushw added the l10n localization label Jul 12, 2022
@m4theushw m4theushw changed the title [DatePickers][l10n] Add esES translations for x-date-pickers [l10n] Add Spanish (es-ES) translations for date pickers Jul 12, 2022
@flaviendelangle flaviendelangle changed the title [l10n] Add Spanish (es-ES) translations for date pickers [pickers] Add Spanish (es-ES) locale Jul 12, 2022
m4theushw
m4theushw approved these changes Jul 12, 2022
View reviewed changes
Copy link
Member

@m4theushw m4theushw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@m4theushw m4theushw merged commit 59a809c into mui:master Jul 12, 2022
@felixh10r felixh10r deleted the patch-3 branch July 13, 2022 14:10
joserodolfofreitas pushed a commit to joserodolfofreitas/mui-x that referenced this pull request Jul 15, 2022
@felixh10r @joserodolfofreitas
[pickers] Add Spanish (es-ES) locale (mui#5468)
51c504c
@megthehoffman
Copy link

@felixh10r thanks for adding this! this doesn't look like it has any bearing on the day of the week labels -- do you know if that functionality included elsewhere?
image

@felixh10r
Copy link
Contributor Author

@megthehoffman the formatting is handled by the LocalizationProvider – did you pass the adapterLocale as detailed here? :)

alexfauquette pushed a commit to alexfauquette/mui-x that referenced this pull request Aug 26, 2022
@felixh10r @alexfauquette
[pickers] Add Spanish (es-ES) locale (mui#5468)
89a0d4e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m4theushw m4theushw m4theushw approved these changes

Assignees
No one assigned
Labels
l10n localization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@felixh10r @mui-bot @megthehoffman @m4theushw