Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data grid] Fix ellipsis style convention #5587

Merged
merged 1 commit into from
Jul 25, 2022

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Jul 24, 2022

Apply https://mui-org.notion.site/Style-guide-2a957a4168a54d47b14bae026d06a24b#a08d92bbbb8249ff8b95431514ab9903.

I have noticed it while having a quick look at #5584. It's also what GitHub uses:

Screenshot 2022-07-24 at 21 44 56

@oliviertassinari oliviertassinari marked this pull request as ready for review July 24, 2022 19:40
@oliviertassinari oliviertassinari added the component: data grid This is the name of the generic UI component, not the React module! label Jul 24, 2022
@mui-bot
Copy link

mui-bot commented Jul 24, 2022

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 260.3 619 430.8 414.86 132.276
Sort 100k rows ms 717 1,089.7 890.3 913.06 120.874
Select 100k rows ms 223.5 396.4 271.9 292.04 60.107
Deselect 100k rows ms 130.5 287.6 199.2 214.76 62.703

Generated by 🚫 dangerJS against 989ccb7

@alexfauquette alexfauquette merged commit 10074bd into mui:master Jul 25, 2022
@oliviertassinari oliviertassinari deleted the fix-ellipsis branch July 25, 2022 11:10
alexfauquette pushed a commit to alexfauquette/mui-x that referenced this pull request Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants