Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGridPremium] Make aggregation public #5592

Merged
merged 3 commits into from
Jul 28, 2022
Merged

[DataGridPremium] Make aggregation public #5592

merged 3 commits into from
Jul 28, 2022

Conversation

cherniavskii
Copy link
Member

@cherniavskii cherniavskii commented Jul 25, 2022 •
edited
Loading

@cherniavskii cherniavskii added the component: data grid This is the name of the generic UI component, not the React module! label Jul 25, 2022
@mui-bot
Copy link

mui-bot commented Jul 25, 2022 •
edited
Loading

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 287.2 603.4 409.3 416.92 104.969
Sort 100k rows ms 474.8 898.2 819.7 748.24 163.08
Select 100k rows ms 220 290.5 250.1 256.38 27.781
Deselect 100k rows ms 147 273.2 195.8 198.16 45.094

Generated by 🚫 dangerJS against c89e163

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 27, 2022
@github-actions

This comment was marked as outdated.

Sign in to view
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 27, 2022
@cherniavskii cherniavskii mentioned this pull request Jul 27, 2022
Merged
10 tasks
joserodolfofreitas
joserodolfofreitas approved these changes Jul 27, 2022
View reviewed changes
Copy link
Member

@joserodolfofreitas joserodolfofreitas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And here we go! 🚀

Outstanding work, @flaviendelangle and @cherniavskii! Really glad to see this combo live.

@cherniavskii cherniavskii merged commit 9270486 into mui:master Jul 28, 2022
@cherniavskii cherniavskii deleted the make-aggregation-public branch July 28, 2022 08:11
@oliviertassinari oliviertassinari added plan: Premium Impact at least one Premium user feature: Aggregation Related to the data grid Aggregation feature labels Aug 7, 2022
alexfauquette pushed a commit to alexfauquette/mui-x that referenced this pull request Aug 26, 2022
@cherniavskii @alexfauquette
[DataGridPremium] Make aggregation public (mui#5592)
36c2253
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joserodolfofreitas joserodolfofreitas joserodolfofreitas approved these changes

@m4theushw m4theushw m4theushw approved these changes

Assignees
No one assigned
Labels
component: data grid This is the name of the generic UI component, not the React module! feature: Aggregation Related to the data grid Aggregation feature plan: Premium Impact at least one Premium user
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@cherniavskii @mui-bot @joserodolfofreitas @m4theushw @oliviertassinari