[test] Fix failing dynamic row height tests on Edge #5707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These are the results for the performance tests:
|
| it('should position correctly the render zone when the 2nd page has less rows than the 1st page', async () => { | ||
| it('should position correctly the render zone when the 2nd page has less rows than the 1st page', async function test() { | ||
| if (/edg/i.test(window.navigator.userAgent)) { | ||
| this.skip(); // FIXME: We need a waitFor that works with fake clock |
There was a problem hiding this comment.
@m4theushw
This test also fails in Chrome and Firefox sometimes:
Firefox 78.0 (Windows 10) <DataGrid /> - Rows prop: getRowHeight dynamic row height should position correctly the render zone when the 2nd page has less rows than the 1st page FAILED
expected inline style of <div …(2)>…(1)</div> did not match
Expected:
{
"transform": "translate3d(0px, 0px, 0px)"
}
Actual:
{
"transform": "translate3d(0px, 988px, 0px)"
}
Chrome 87.0.4280.66 (Mac OS 10.15.6) <DataGrid /> - Rows prop: getRowHeight dynamic row height should position correctly the render zone when the 2nd page has less rows than the 1st page FAILED
AssertionError: expected inline style of <div …(2)></div> did not match
Expected:
{
"transform": "translate3d(0px, 0px, 0px)"
}
Actual:
{
"transform": "translate3d(0px, 1040px, 0px)"
}
I can reproduce it locally using Chrome instead of ChromeHeadless.
Test fails only when browser window is in background.
diff --git a/test/karma.conf.js b/test/karma.conf.js
index 2ea932985..f40b51137 100644
--- a/test/karma.conf.js
+++ b/test/karma.conf.js
@@ -44,7 +44,7 @@ const MAX_CIRCLE_CI_CONCURRENCY = 83;
module.exports = function setKarmaConfig(config) {
const baseConfig = {
basePath: '../',
- browsers: ['chromeHeadless'],
+ browsers: ['Chrome'],
browserDisconnectTimeout: 3 * 60 * 1000, // default 2000
browserDisconnectTolerance: 1, // default 0
browserNoActivityTimeout: 6 * 60 * 1000, // default 10000Any ideas?
There was a problem hiding this comment.
I don't have any clue of why they fail. When I did this PR, I only had problems with Edge so ignoring this browser in this specific test solved the problem. https://app.circleci.com/pipelines/github/mui/mui-x/21728/workflows/12ccc593-a493-414b-9484-79cb96b8a991/jobs/125448 is from a7eef9e
I think we'll need to skip all tests related to dynamic row height since they are too flacky.
alexfauquette
pushed a commit
to alexfauquette/mui-x
that referenced
this pull request
Aug 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests are failing on Edge after the merge of #4155