[test] Share karma setup #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanailH
reviewed
Nov 16, 2020
| @@ -68,6 +68,7 @@ describe('<XGrid />', () => { | |||
| }); | |||
|
|
|||
| describe('keyboard', () => { | |||
| /* eslint-disable material-ui/disallow-active-element-as-key-event-target */ | |||
There was a problem hiding this comment.
Can we remove this? Is it difficult to fix the error?
There was a problem hiding this comment.
It's by design, there are rare cases, like this one, where the tradeoff is ok. See mui/material-ui#23488. But most of the time, it should be discouraged, I think. The fire event shouldn't use activeElement, it makes the logic harder to think about.
DanailH
approved these changes
Nov 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, enable caching for the documentation with Next.js and Netlify, it should build faster.