Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Update GridCellParams value description #5849

Merged
merged 7 commits into from
Aug 26, 2022
Merged

[docs] Update GridCellParams value description #5849

merged 7 commits into from
Aug 26, 2022

Conversation

cherniavskii
Copy link
Member

Closes #5823

@cherniavskii cherniavskii added docs Improvements or additions to the documentation component: data grid This is the name of the generic UI component, not the React module! labels Aug 19, 2022
cherniavskii
cherniavskii commented Aug 19, 2022
View reviewed changes
packages/grid/x-data-grid/src/models/params/gridCellParams.ts
@@ -106,6 +106,10 @@ export interface GridValueGetterParams<V = any, R = any>
* @deprecated Use the `apiRef` returned by `useGridApiContext` or `useGridApiRef` (only available in `@mui/x-data-grid-pro`)
*/
api: any;
/**
* The default value for the cell that the `valueGetter` is overriding.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To override GridCellParams['value'] description for valueGetter, since it doesn't make sense in that case (see #5823 (comment))

@mui-bot
Copy link

mui-bot commented Aug 19, 2022 •
edited
Loading

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 317.3 870.9 473.9 498.96 200.844
Sort 100k rows ms 460.7 980.5 870.9 809.44 186.86
Select 100k rows ms 165.7 283 232.4 226.64 45.813
Deselect 100k rows ms 131.9 285.2 252.5 224.52 54.073

Generated by 🚫 dangerJS against ab1b3ec

@cherniavskii cherniavskii merged commit 8b306b7 into mui:master Aug 26, 2022
@cherniavskii cherniavskii deleted the GridCellParams-value branch August 26, 2022 11:39
@m4theushw m4theushw mentioned this pull request Sep 1, 2022
Merged
14 tasks
alexfauquette pushed a commit to alexfauquette/mui-x that referenced this pull request Sep 20, 2022
@cherniavskii @m4theushw @alexfauquette
[docs] Update GridCellParams value description (mui#5849)
c619d28 
Co-authored-by: Matheus Wichman <matheushw@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m4theushw m4theushw m4theushw approved these changes

Assignees
No one assigned
Labels
component: data grid This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DataGrid valueGetter has confusing intellisense
3 participants
@cherniavskii @mui-bot @m4theushw