Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] Add sort prop to columns panel slot #5888

Merged
merged 11 commits into from
Aug 29, 2022
Merged

[DataGrid] Add sort prop to columns panel slot #5888

merged 11 commits into from
Aug 29, 2022

Conversation

gavbrennan
Copy link
Contributor

@gavbrennan gavbrennan commented Aug 24, 2022 •
edited by alexfauquette
Loading

Fix #5830

Adds ability to specify a sort order for display of columns in column picker, without changing the order of the columns themselves.

@mui-bot
Copy link

mui-bot commented Aug 24, 2022 •
edited
Loading

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 340.3 877.1 504.5 517.3 193.009
Sort 100k rows ms 469.9 1,095.3 829.5 836.08 204.08
Select 100k rows ms 220.6 301.1 285.9 273.14 28.726
Deselect 100k rows ms 126.4 309.3 206.2 205.96 63.574

Generated by 🚫 dangerJS against 091b541

@gavbrennan gavbrennan marked this pull request as draft August 24, 2022 05:55
@gavbrennan gavbrennan marked this pull request as ready for review August 24, 2022 10:16
@gavbrennan
Copy link
Contributor Author

@m4theushw if you are interested

@flaviendelangle flaviendelangle changed the title Adds optional alphabetical sorting to data grid column picker [data grid] Adds optional alphabetical sorting to data grid column picker Aug 24, 2022
gavbrennan and others added 2 commits August 26, 2022 14:39
@gavbrennan @m4theushw
Update packages/grid/x-data-grid/src/components/panel/GridColumnsPane…
f374924 
…l.tsx

Co-authored-by: Matheus Wichman <matheushw@outlook.com>
Signed-off-by: Gavin Brennan <gavbrennan@hotmail.com>
@gavbrennan
props to other
b8b6dc2
alexfauquette
alexfauquette approved these changes Aug 26, 2022
View reviewed changes
Copy link
Member

@alexfauquette alexfauquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me 🚀

m4theushw
m4theushw approved these changes Aug 26, 2022
View reviewed changes
Copy link
Member

@m4theushw m4theushw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@m4theushw m4theushw changed the title [data grid] Adds optional alphabetical sorting to data grid column picker [DataGrid] Add sort prop to columns panel slot Aug 26, 2022
@alexfauquette alexfauquette merged commit c68c2f6 into mui:master Aug 29, 2022
alexfauquette added a commit to alexfauquette/mui-x that referenced this pull request Sep 20, 2022
@gavbrennan @m4theushw @alexfauquette
[DataGrid] Add sort prop to columns panel slot (mui#5888)
8888ec2 
Co-authored-by: Matheus Wichman <matheushw@outlook.com>
Co-authored-by: Alexandre Fauquette <alex.fauquette@gmail.com>
@oliviertassinari oliviertassinari added the component: data grid This is the name of the generic UI component, not the React module! label Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m4theushw m4theushw m4theushw approved these changes

@alexfauquette alexfauquette alexfauquette approved these changes

Assignees
No one assigned
Labels
component: data grid This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[data grid] Add prop to customize sort order in the columns panel
5 participants
@gavbrennan @mui-bot @m4theushw @alexfauquette @oliviertassinari