Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Add description and default to pickers slots #5893

Merged
merged 9 commits into from
Aug 26, 2022
Merged

[docs] Add description and default to pickers slots #5893

merged 9 commits into from
Aug 26, 2022

Conversation

alexfauquette
Copy link
Member

No description provided.

@alexfauquette alexfauquette added the docs Improvements or additions to the documentation label Aug 24, 2022
@mui-bot
Copy link

mui-bot commented Aug 24, 2022 •
edited
Loading

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 318.9 892.2 417.6 501.58 212.019
Sort 100k rows ms 542 968 841.2 800.46 144.088
Select 100k rows ms 180.6 389.6 239.1 259.74 74.366
Deselect 100k rows ms 135.2 266.3 200.9 193.54 46.942

Generated by 🚫 dangerJS against 1b1a52c

LukasTy
LukasTy approved these changes Aug 26, 2022
View reviewed changes
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than that small quibble with OpenPickerIcon description. 🙌

@alexfauquette alexfauquette merged commit 6b9857b into mui:master Aug 26, 2022
@LukasTy LukasTy mentioned this pull request Sep 1, 2022
Merged
14 tasks
@flaviendelangle flaviendelangle mentioned this pull request Sep 2, 2022
Merged
alexfauquette added a commit to alexfauquette/mui-x that referenced this pull request Sep 20, 2022
@alexfauquette
[docs] Add description and default to pickers slots (mui#5893)
4c72864
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasTy LukasTy LukasTy approved these changes

@flaviendelangle flaviendelangle Awaiting requested review from flaviendelangle

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alexfauquette @mui-bot @LukasTy