[pickers] Do not require date-fns in @mui/x-date-pickers-pro
#5941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaviendelangle
added
regression
|
These are the results for the performance tests:
|
alexfauquette
approved these changes
Aug 29, 2022
There was a problem hiding this comment.
That's an unexpected consequence of the experiment 🤯
I confirm the regression is fixed by this PR
issue reproduction: https://codesandbox.io/s/admiring-bird-djug44?file=/index.tsx
issue reproduction with the fix: https://codesandbox.io/s/bold-germain-jt0dsl?file=/demo.tsx:133-170
LukasTy
reviewed
Aug 29, 2022
| // We don't add those exports to the regular `@mui/x-date-pickers/internals`, | ||
| // Because they rely on date-fns, which is not used by all applications. | ||
| export { | ||
| useField, |
There was a problem hiding this comment.
I'd say that we should still look into removing the direct dependency of date-fns from useField.utls going forward 🤔
There was a problem hiding this comment.
Yes I think we all agree on that
I requires new methods in the adapter so it was not feasable for a simple POC
But the components can't be stable with hardcoded date-fns stuff
alexfauquette
pushed a commit
to alexfauquette/mui-x
that referenced
this pull request
Sep 20, 2022
…#5941) [pickers] Do not require date-fns in @mui/x-date-pickers-pro
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5916