Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGridPremium] Use the aggregated value on tree data real groups #5953

Merged
merged 5 commits into from
Aug 30, 2022

Conversation

flaviendelangle
Copy link
Member

@flaviendelangle flaviendelangle commented Aug 30, 2022

Fixes #5923

Two fixes for the aggregation used with tree data:

  • When using a tree of depth < 2, do not aggregate a group based on both a child group and this child group childrens
  • Correctly render the aggregated value instead of the provided value on data group like told in the doc

Demo: https://codesandbox.io/s/nameless-worker-oox3gk?file=/demo.tsx

@flaviendelangle flaviendelangle self-assigned this Aug 30, 2022
@mui-bot
Copy link

mui-bot commented Aug 30, 2022

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 338.1 605.8 447.5 478.94 103.329
Sort 100k rows ms 520.8 836.8 801.2 754.5 118.497
Select 100k rows ms 135.6 282.1 218.6 216.24 47.12
Deselect 100k rows ms 139.3 317.6 189.1 223.92 69.952

Generated by 🚫 dangerJS against c0fea18

@flaviendelangle flaviendelangle added the bug 🐛 Something doesn't work label Aug 30, 2022
@flaviendelangle flaviendelangle marked this pull request as draft August 30, 2022 08:41
@flaviendelangle flaviendelangle marked this pull request as ready for review August 30, 2022 09:20
@flaviendelangle flaviendelangle merged commit 8fc694e into mui:master Aug 30, 2022
@flaviendelangle flaviendelangle deleted the tree-data-aggregation branch August 30, 2022 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work
Projects
None yet
3 participants