Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Fix time zone sensitive test #5955

Merged
merged 3 commits into from
Aug 30, 2022
Merged

Conversation

LukasTy
Copy link
Member

@LukasTy LukasTy commented Aug 30, 2022

Try fixing test failing in Edge due to different timezone mentioned here.
Tested locally by setting explicit process TZ of America/Los_Angeles.
Another change that could work and potentially reduce future issues - setting explicit time zone for karma tests.

@mui-bot
Copy link

mui-bot commented Aug 30, 2022

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 331.1 739.5 502.8 483.54 150.014
Sort 100k rows ms 468 1,022.4 700.9 821.12 208.713
Select 100k rows ms 275.2 294.3 291.1 287.24 7.514
Deselect 100k rows ms 125.1 298.8 189.5 209.86 71.076

Generated by 🚫 dangerJS against 28b8f1a

@m4theushw
Copy link
Member

Could you apply the diff below and commit? It will force to run all browsers so we can see if there's no more test failing. Once is green please revert the commit.

diff --git a/.circleci/config.yml b/.circleci/config.yml
index 9607e2d4a..5735a23b8 100644
--- a/.circleci/config.yml
+++ b/.circleci/config.yml
@@ -194,6 +194,8 @@ jobs:
       - run:
           name: Tests real browsers
           command: yarn test:karma
+          environment:
+            BROWSERSTACK_FORCE: 'true'
       - store_artifacts:
           # hardcoded in karma-webpack
           path: /tmp/_karma_webpack_

@LukasTy LukasTy merged commit 1b43166 into mui:master Aug 30, 2022
@LukasTy LukasTy deleted the fix-flaky-date-test branch August 30, 2022 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants